Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve error message when no file or directory was found #48

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

vbreuss
Copy link
Member

@vbreuss vbreuss commented Sep 5, 2023

When no matching file or directory was found in a directory, improve the error message to specify that "none" was found instead of the simple count (0).

@vbreuss vbreuss added the refactor A change or improvement without functional impact label Sep 5, 2023
@vbreuss vbreuss self-assigned this Sep 5, 2023
@vbreuss vbreuss enabled auto-merge (squash) September 5, 2023 06:58
@vbreuss vbreuss changed the title refactor: error message when no file or directory was found refactor: improve error message when no file or directory was found Sep 5, 2023
@vbreuss vbreuss merged commit 5364317 into main Sep 5, 2023
7 checks passed
@vbreuss vbreuss deleted the topic/vb/refactor-error-message-when-none-was-found branch September 5, 2023 07:08
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

This is addressed in release v0.8.0.

mergify bot referenced this pull request in Testably/Testably.Abstractions Sep 5, 2023
… to v0.8.0 (#396)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[Testably.Abstractions.FluentAssertions](https://github.com/Testably/Testably.Abstractions.FluentAssertions)
| nuget | minor | `0.7.0` -> `0.8.0` |

---

### Release Notes

<details>
<summary>Testably/Testably.Abstractions.FluentAssertions
(Testably.Abstractions.FluentAssertions)</summary>

###
[`v0.8.0`](https://github.com/Testably/Testably.Abstractions.FluentAssertions/releases/tag/v0.8.0)

#### What's Changed

- chore(deps): update actions/checkout action to v4 by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/Testably/Testably.Abstractions.FluentAssertions/pull/45](https://github.com/Testably/Testably.Abstractions.FluentAssertions/pull/45)
- chore(deps): update danielpalme/reportgenerator-github-action action
to v5.1.25 by [@&#8203;renovate](https://github.com/renovate) in
[https://github.com/Testably/Testably.Abstractions.FluentAssertions/pull/46](https://github.com/Testably/Testably.Abstractions.FluentAssertions/pull/46)
- feat: add assertions for `HasFileShare` by
[@&#8203;vbreuss](https://github.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions.FluentAssertions/pull/47](https://github.com/Testably/Testably.Abstractions.FluentAssertions/pull/47)
- refactor: improve error message when no file or directory was found by
[@&#8203;vbreuss](https://github.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions.FluentAssertions/pull/48](https://github.com/Testably/Testably.Abstractions.FluentAssertions/pull/48)
- refactor: add regex timeout by
[@&#8203;vbreuss](https://github.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions.FluentAssertions/pull/49](https://github.com/Testably/Testably.Abstractions.FluentAssertions/pull/49)

**Full Changelog**:
Testably/Testably.Abstractions.FluentAssertions@v0.7.0...v0.8.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Testably/Testably.Abstractions).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi43OS4xIiwidXBkYXRlZEluVmVyIjoiMzYuNzkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A change or improvement without functional impact state: released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant