refactor: Replace Task.Factory.StartNew with Task.Run

Source/Testably.Abstractions.Testing/FileSystem/FileSystemWatcherMock.cs

@@ -295,7 +295,7 @@ private void Start()
 						InternalBufferSize, channelCapacity)));
 			}
 		});
-		Task.Factory.StartNew(() =>
+		Task.Run(() =>
 				{
 					try
 					{
@@ -312,9 +312,7 @@ private void Start()
 						//Ignore any exception
 					}
 				},
-				token,
-				TaskCreationOptions.LongRunning,
-				TaskScheduler.Default)
+				token)
 			.ContinueWith(_ =>
 			{
 				if (channel.Writer.TryComplete())

Source/Testably.Abstractions.Testing/Notification.cs

@@ -107,7 +107,7 @@ public void Wait(Func<TValue, bool>? filter = null,
 				Task? task = null;
 				if (executeWhenWaiting != null)
 				{
-					task = Task.Factory.StartNew(executeWhenWaiting.Invoke);
+					task = Task.Run(executeWhenWaiting.Invoke);
 				}
 
 				if (!_reset.Wait(timeout) ||

Source/Testably.Abstractions.Testing/TimeSystem/ThreadMock.cs

@@ -34,7 +34,7 @@ public void Sleep(TimeSpan timeout)
 		}
 
 		_mockTimeSystem.TimeProvider.AdvanceBy(timeout);
-		Thread.Sleep(0);
+		Thread.Yield();
 		_callbackHandler.InvokeThreadSleepCallbacks(timeout);
 	}
 

Tests/Testably.Abstractions.AccessControl.Tests/DirectoryAclExtensionsTests.cs

@@ -1,4 +1,5 @@
 using System.Security.AccessControl;
+using System.Threading.Tasks;
 using Testably.Abstractions.AccessControl.Tests.TestHelpers;
 
 namespace Testably.Abstractions.AccessControl.Tests;
@@ -96,14 +97,14 @@ public void SetAccessControl_ShouldChangeAccessControl()
 	}
 
 	[SkippableFact]
-	public void SetAccessControl_ShouldNotUpdateTimes()
+	public async Task SetAccessControl_ShouldNotUpdateTimes()
 	{
 		Skip.IfNot(Test.RunsOnWindows);
 
 		Test.SkipIfLongRunningTestsShouldBeSkipped(FileSystem);
 
 		FileSystem.File.WriteAllText("foo.txt", "abc");
-		TimeSystem.Thread.Sleep(3000);
+		await TimeSystem.Task.Delay(3000);
 		DateTime previousCreationTimeUtc = FileSystem.File.GetCreationTimeUtc("foo.txt");
 		DateTime previousLastAccessTimeUtc = FileSystem.File.GetLastAccessTimeUtc("foo.txt");
 		DateTime previousLastWriteTimeUtc = FileSystem.File.GetLastWriteTimeUtc("foo.txt");

Tests/Testably.Abstractions.AccessControl.Tests/DirectoryInfoAclExtensionsTests.cs

@@ -1,5 +1,6 @@
 using AutoFixture.Xunit2;
 using System.Security.AccessControl;
+using System.Threading.Tasks;
 using Testably.Abstractions.AccessControl.Tests.TestHelpers;
 
 namespace Testably.Abstractions.AccessControl.Tests;
@@ -98,14 +99,14 @@ public void SetAccessControl_ShouldChangeAccessControl()
 
 	[SkippableTheory]
 	[AutoData]
-	public void SetAccessControl_ShouldNotUpdateTimes(string path)
+	public async Task SetAccessControl_ShouldNotUpdateTimes(string path)
 	{
 		Skip.IfNot(Test.RunsOnWindows);
 
 		Test.SkipIfLongRunningTestsShouldBeSkipped(FileSystem);
 
 		FileSystem.Directory.CreateDirectory(path);
-		TimeSystem.Thread.Sleep(3000);
+		await TimeSystem.Task.Delay(3000);
 		DateTime previousCreationTimeUtc = FileSystem.File.GetCreationTimeUtc(path);
 		DateTime previousLastAccessTimeUtc = FileSystem.File.GetLastAccessTimeUtc(path);
 		DateTime previousLastWriteTimeUtc = FileSystem.File.GetLastWriteTimeUtc(path);

Tests/Testably.Abstractions.Testing.Tests/FileSystem/FileSystemWatcherMockTests.cs

@@ -179,7 +179,6 @@ public void InternalBufferSize_ShouldResetQueue(string path1, string path2)
 		}
 
 		block2.Wait(100).Should().BeFalse();
-		fileSystemWatcher.Dispose();
 		result.Should().BeNull();
 	}
 }

Tests/Testably.Abstractions.Testing.Tests/MockTimeSystemTests.cs

@@ -70,7 +70,7 @@ public void Sleep_InfiniteTimeSpan_ShouldNotThrowException()
 	}
 
 	[Fact]
-	public void Sleep_LessThanInfinite_ShouldNotThrowException()
+	public void Sleep_LessThanInfinite_ShouldThrowArgumentOutOfRangeException()
 	{
 		MockTimeSystem timeSystem = new();
 		Exception? exception =
@@ -80,7 +80,7 @@ public void Sleep_LessThanInfinite_ShouldNotThrowException()
 	}
 
 	[Fact]
-	public void Sleep_LessThanInfiniteTimeSpan_ShouldNotThrowException()
+	public void Sleep_LessThanInfiniteTimeSpan_ShouldThrowArgumentOutOfRangeException()
 	{
 		MockTimeSystem timeSystem = new();
 		Exception? exception =

Tests/Testably.Abstractions.Tests/FileSystem/FileSystemWatcher/Tests.cs

@@ -92,7 +92,7 @@ public void EndInit_ShouldRestartListening(string path)
 				}
 			});
 			IWaitForChangedResult result =
-				fileSystemWatcher.WaitForChanged(WatcherChangeTypes.Created, 100);
+				fileSystemWatcher.WaitForChanged(WatcherChangeTypes.Created, 30000);
 
 			fileSystemWatcher.EnableRaisingEvents.Should().BeTrue();
 			result.TimedOut.Should().BeFalse();