fix: Throw correct exception when using File.Replace with case-only changes on MacOS
#638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stryker.NET mutation tested the changes in the pull request: |
vbreuss
changed the title
File.Copy, File.Move and File.ReplaceFile.Replace with case-only changes on MacOS
|
vbreuss
deleted the
topic/test-caseonly-change-for-copy-move-and-replace
branch
|
This is addressed in release v3.2.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
File.Replacewith source and destination only differing in casing, on MacOS the file system throws an exception that "Source and destination path must be different". Consider this case also in theMockFileSystem.Also add tests for correct handling of case-only changes in
File.MoveandFile.Copy.Note: This fix was inspired by TestableIO/System.IO.Abstractions#1140 and TestableIO/System.IO.Abstractions#1138.