Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress5 updates #665

Merged
merged 7 commits into from
Nov 30, 2022
Merged

Progress5 updates #665

merged 7 commits into from
Nov 30, 2022

Conversation

blazyy
Copy link
Contributor

@blazyy blazyy commented Nov 28, 2022

No description provided.

xieyt2000
xieyt2000 suggested changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@xieyt2000 xieyt2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check:
Some repos aren't archived. Did you find them manually or use some scripts?
For MovedOrRenamed, add new rows for the renamed tests
For Deleted, try to find when it was deleted

py-data.csv Outdated Show resolved Hide resolved
py-data.csv Show resolved Hide resolved
py-data.csv Outdated Show resolved Hide resolved
@blazyy
Copy link
Contributor Author

blazyy commented Nov 29, 2022

@xieyt2000 Some of my PRs were closed by the developer- I've update their statuses as Rejected (7e63214) currently but could you take a look at them? I'm wondering if they should fall under Rejected or DeveloperWontFix?

PRs:
fooof-tools/fooof#242
fooof-tools/fooof#243

@darko-marinov
Copy link
Contributor

DeveloperWontFix is when you don't even open a PR. I'll let @xieyt2000 inspect the details. Not all Rejected are treated the same.

xieyt2000
xieyt2000 suggested changes Nov 29, 2022
View reviewed changes
py-data.csv Outdated Show resolved Hide resolved
py-data.csv Show resolved Hide resolved
py-data.csv Show resolved Hide resolved
py-data.csv Outdated Show resolved Hide resolved
@blazyy
Copy link
Contributor Author

blazyy commented Nov 30, 2022

@xieyt2000 Added all the changes you requested, let me know if I missed anything

xieyt2000
xieyt2000 approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@xieyt2000 xieyt2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darko-marinov darko-marinov merged commit a0c7012 into TestingResearchIllinois:main Nov 30, 2022
@darko-marinov
Copy link
Contributor

Accepting per Yuntong's approval. Please open smaller PRs in the future.

blazyy added a commit to blazyy/idoft that referenced this pull request Dec 2, 2022
@blazyy
Progress5 updates (TestingResearchIllinois#665)
abf81de 
Squashed 7 commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xieyt2000 xieyt2000 xieyt2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blazyy @darko-marinov @xieyt2000