Fix repr highlighter #1920
Merged
Fix repr highlighter #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enum.Flag allows more than one bit to be set, and its repr will show something like <Permission.READ|WRITE: 3>. For this to display correctly, we need to add the pipe symbol to the tag regex.
Special characters lose their special meaning in character sets, so there's no need to escape them with a backslash. Furthermore, some backslash escaped characters have no special meaning, so the backslash can be removed as well. "]" does normally close a set, except when it's the first character. Similarly, "-" has no special meaning at the beginning or the end. Therefore, the order in a few character sets had to be slightly modified. Just to be sure, the old and new versions of the regexp were confirmed to be equivalent via re.compile with the re.DEBUG flag and comparing the output.
Codecov Report
@@ Coverage Diff @@
## master #1920 +/- ##
==========================================
- Coverage 99.82% 99.81% -0.02%
==========================================
Files 71 71
Lines 6943 7033 +90
==========================================
+ Hits 6931 7020 +89
- Misses 12 13 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
willmcgugan
approved these changes
Feb 11, 2022
|
THanks |
This was referenced Mar 10, 2022
This was referenced Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
This PR contains 2 changes:
enum.Flag supports more than one bit to be set, and it is displayed like
<Permission.READ|WRITE: 3>. The|character was not recognised by ReprHighlighter as part of a tag_name, causing only the first part to be highlighted.This is purely cosmetic, but I found the regexes to be really difficult to parse because of all the backslashes. Most of those actually weren't necessary, the commit explains the details further. However, this commit is completely optional.