Fix missing mode
property on file wrapper
#2495
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the missing
mode
property to the file wrapper used byrich.progress.wrap_file
.This fixes an incompatibility with the requests library.
Type of changes
Checklist
Description
Without this property, uploads using
requests
fail to set theContent-Length
header, and fall back to chunked encoding,which many hosts (e.g. S3) don't support.
requests
uses themode
property in itssuper_len
function, which determines the length of the stream to upload.
Example Code (Fragment)
Before fix
Request headers
Response
After fix
Request headers
Response