-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
context sensitive help #4915
context sensitive help #4915
Conversation
Should the sidebar have a title of "Help", or the name of the widget that the help is being displayed for? Or customisable? Or nothing? 😄 |
This looks good to me but I think I'd want a title personally (which could always be hidden with |
How about this? Screen.Recording.2024-08-22.at.10.53.25.mov |
I agree it doesn't look great there! Maybe you're right 😄 |
How about I hide it by default. And if a dev asks, they can unhide it? |
Seems like a reasonable compromise. |
Done. Can I get a 👍 |
Could you add a snapshot test? After that it LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
DOMNodes now have a
HELP
classvar which may be set to Markdown that renders in the help panel.