-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASVideoNode delegate respondsToSelector crash. #291
Comments
Hi @ArmandsB ! Quick fix would be to simply implement protocol ASVideoNodeDelegate with didFailToLoadValueForKey method. But right solution will be to add necessary checks to ASVideoNode.mm . I submitted this code in PR last week and obviously forgot to add flags and these checks to .mm file as i'm more Swift developer than ObjC and I cannot just leave something from swift protocol not implemented behind. Sorry for inconvenience |
…ash an app because of not responding to selector; refs TextureGroup#291
* Fixed bug where ASVideoNodeDelegate error reporting callback would crash an app because of not responding to selector; refs TextureGroup#291 * updated changelog.md * fixed typo in const name of ASVideoNodeDelegate method in delegate flags; refs TextureGroup#292
* Fixed bug where ASVideoNodeDelegate error reporting callback would crash an app because of not responding to selector; refs TextureGroup#291 * updated changelog.md * fixed typo in const name of ASVideoNodeDelegate method in delegate flags; refs TextureGroup#292
Hello. I noticed that at line 156 @ ASVideoNode.mm class calls delegate function before checking if it's implemented.
The text was updated successfully, but these errors were encountered: