Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding buildkite support #1

Merged
merged 2 commits into from
Mar 7, 2017
Merged

Adding buildkite support #1

merged 2 commits into from
Mar 7, 2017

Conversation

garrettmoon
Copy link
Member

No description provided.

@garrettmoon garrettmoon merged this pull request into master Mar 7, 2017
@Adlai-Holler Adlai-Holler deleted the addBuildKiteSupport branch March 9, 2017 21:52
garrettmoon added a commit that referenced this pull request Mar 15, 2017
* Adding buildkite support

* Update build.sh to support all flag
garrettmoon added a commit that referenced this pull request Apr 7, 2017
* Adding buildkite support

* Update build.sh to support all flag
garrettmoon added a commit that referenced this pull request Apr 11, 2017
* Adding buildkite support

* Update build.sh to support all flag
garrettmoon added a commit that referenced this pull request Apr 13, 2017
* Adding buildkite support

* Update build.sh to support all flag
garrettmoon added a commit that referenced this pull request Apr 14, 2017
* Adding buildkite support

* Update build.sh to support all flag
garrettmoon added a commit that referenced this pull request Apr 14, 2017
* Adding buildkite support

* Update build.sh to support all flag
harryworld pushed a commit to harryworld/Texture that referenced this pull request Aug 28, 2017
nguyenhuy added a commit to nguyenhuy/Texture that referenced this pull request Oct 2, 2018
This is a follow up on TextureGroup#1136. Our experiment results show that clearing data frequently is the cause of our TextureGroup#1 crash. @maicki and I believe that this is because if the collection view is being used, silently clearing its data without notifying the backing UICollectionView can put it out-of-sync and causes mayhem next time the collection view processes a batch update. If you look at the stack trace closely, you'll notice that the crash doesn't occur on the same run loop that clearData is called. This made it extremely tricky to investigate and identify the root cause.

Another interesting question would be whether or not we want to clear the data during deallocation at all, since the data will be cleared out soon anyway.
nguyenhuy added a commit that referenced this pull request Oct 3, 2018
This is a follow up on #1136. Our experiment results show that clearing data frequently is the cause of our #1 crash. @maicki and I believe that this is because if the collection view is being used, silently clearing its data without notifying the backing UICollectionView can put it out-of-sync and causes mayhem next time the collection view processes a batch update. If you look at the stack trace closely, you'll notice that the crash doesn't occur on the same run loop that clearData is called. This made it extremely tricky to investigate and identify the root cause.

Another interesting question would be whether or not we want to clear the data during deallocation at all, since the data will be cleared out soon anyway.
raviTokopedia pushed a commit to raviTokopedia/Texture that referenced this pull request Mar 5, 2020
benniebotha pushed a commit to atlassian-forks/Texture that referenced this pull request Jun 28, 2021
…request TextureGroup#1)

CYC-317 Updated texture to use latest PIN frameworks so that it can build in Xcode 12

Approved-by: Anton Soloviev
Approved-by: Thi Hon
Approved-by: Rob Chatfield
Approved-by: Rajdeep Kwatra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant