Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't setNeedsDisplay on text node 2 measure #trivial #1116

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Don't setNeedsDisplay on text node 2 measure #trivial #1116

merged 1 commit into from
Sep 13, 2018

Conversation

Adlai-Holler
Copy link
Member

@Adlai-Holler Adlai-Holler commented Sep 12, 2018 •
edited
Loading

  • This call was copied from TextNode1.
  • Git blame there not helpful.
  • Not causing problems right now.
  • Doesn't belong.
  • We have needsDisplayOnBoundsChange=YES in init.

@Adlai-Holler Adlai-Holler merged commit 1d2f1f2 into master Sep 13, 2018
@Adlai-Holler Adlai-Holler deleted the AHDontInvalidateDisplayOnMeasure branch September 13, 2018 18:05
mikezucc pushed a commit to mikezucc/Texture that referenced this pull request Oct 2, 2018
@Adlai-Holler @mikezucc
Don't setNeedsDisplay on text node measure #trivial (TextureGroup#1116)
c8b22e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maicki maicki maicki approved these changes

@garrettmoon garrettmoon Awaiting requested review from garrettmoon

@appleguy appleguy Awaiting requested review from appleguy

@nguyenhuy nguyenhuy Awaiting requested review from nguyenhuy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Adlai-Holler @maicki