Fix the build warning in ASRangeController.mm
#1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhuy
requested changes
Jul 10, 2019
Source/Details/ASRangeController.mm
Outdated
| @@ -399,7 +400,7 @@ - (void)_updateVisibleNodeIndexPaths | |||
| if (ASDisplayNode.shouldShowRangeDebugOverlay) { | |||
| ASScrollDirection scrollableDirections = ASScrollDirectionUp | ASScrollDirectionDown; | |||
| if ([_dataSource isKindOfClass:NSClassFromString(@"ASCollectionView")]) { | |||
| scrollableDirections = ((ASCollectionView *)_dataSource).scrollableDirections; | |||
| scrollableDirections = ((ASCollectionView *)_dataSource).collectionNode.scrollableDirections; | |||
There was a problem hiding this comment.
I agree that we should fix this warning. However, given that this is a legitimate usage of the collection view's property, I don't think this is the best fix. Another way to fix it is simply importing ASCollectionView+Undeprecated.h. We have done this elsewhere in the framework.
hanton
force-pushed
the
fix-build-warning
branch
from
d9803ef to
edfbec9
Compare
|
hi @nguyenhuy , thanks for pointing this out, I've updated the commit :P |
nguyenhuy
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following warning in the build process: