Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new networking image delegate method when image does not load from cache #1590

Merged
merged 5 commits into from
Jul 19, 2019
Merged

add new networking image delegate method when image does not load from cache #1590

merged 5 commits into from
Jul 19, 2019

Conversation

ernestmama
Copy link
Contributor

There is a missing delegate when image cannot load from cache.

@ernestmama
add new networking image delegate method when image does not laod from
9d4018d 
cache
@ernestmama
Merge branch 'networkingImageNodeDelegateUpdate' of github.com:ernest…
4e148d1 
…mama/Texture into networkingImageNodeDelegateUpdate

# Conflicts:
#	Source/ASNetworkImageNode.mm
nguyenhuy
nguyenhuy requested changes Jul 19, 2019
View reviewed changes
Copy link
Member

@nguyenhuy nguyenhuy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still doesn't cover the case in which the cache load was cancelled. From our offline discussion, I think agreed to not add this API but address the root cause (multiple cache loads are executed with the same URL) instead?

nguyenhuy
nguyenhuy requested changes Jul 19, 2019
View reviewed changes
Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is a slightly different issue. This new API allows clients to know when the node failed to load from cache without having to infer/guess from -imageNodeWillLoadImageFromNetwork:.

Source/ASNetworkImageNode.h Outdated Show resolved Hide resolved
@ernestmama
Merge branch 'networkingImageNodeDelegateUpdate' of github.com:ernest…
75241c6 
…mama/Texture into networkingImageNodeDelegateUpdate
@ernestmama
Merge branch 'networkingImageNodeDelegateUpdate' of github.com:ernest…
d988ceb 
…mama/Texture into networkingImageNodeDelegateUpdate
nguyenhuy
nguyenhuy approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@nguyenhuy nguyenhuy merged commit 9c537ea into TextureGroup:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenhuy nguyenhuy nguyenhuy approved these changes

@rqueue rqueue rqueue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ernestmama @nguyenhuy @rqueue