Update ASPendingState backgroundColor type to UIColor #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhuy
requested changes
Jul 19, 2019
| } | ||
|
|
||
| - (void)setBackgroundColor:(UIColor *)newBackgroundColor | ||
| { | ||
| _bridge_prologue_write; | ||
|
|
||
| CGColorRef newBackgroundCGColor = [newBackgroundColor CGColor]; |
There was a problem hiding this comment.
Nit: Since newBackgroundCGColor is always set below, let's leave it nil at first.
Source/Private/_ASPendingState.mm
Outdated
| @@ -18,7 +18,7 @@ | |||
|
|
|||
| #define __shouldSetNeedsDisplay(layer) (flags.needsDisplay \ | |||
| || (flags.setOpaque && _flags.opaque != (layer).opaque)\ | |||
| || (flags.setBackgroundColor && !CGColorEqualToColor(backgroundColor, (layer).backgroundColor))) | |||
| || (flags.setBackgroundColor && [backgroundColor isEqual:[UIColor colorWithCGColor:(layer).backgroundColor]])) | |||
There was a problem hiding this comment.
Suggested change
| || (flags.setBackgroundColor && [backgroundColor isEqual:[UIColor colorWithCGColor:(layer).backgroundColor]])) | |
| || (flags.setBackgroundColor && ! [backgroundColor isEqual:[UIColor colorWithCGColor:(layer).backgroundColor]])) |
its new dynamic capabilties
rahul-malik
force-pushed
the
rmalik/cgcolor-uicolor
branch
from
96dd70c to
5f06a7b
Compare
rahul-malik
added a commit
that referenced
this pull request
Jul 20, 2019
…ing its new dynamic capabilties (#1592)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that UIColor is now a dynamic provider we can no longer rely on the fact that there is a 1:1 mapping between UIColor <-> CGColorRef.
I've updated the UIViewBridge and ASPendingState accordingly to use UIColor and translate to CGColorRef only when interacting with layers. This should preserve any dynamic capabilities we might need in the future when trying to re-render layer backed nodes.
Depends on #1588