use iOS 13.0 and Xcode 11 on CI #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vovasty
force-pushed
the
vlad/build-ios13
branch
7 times, most recently
from
8e02d00 to
79688bf
Compare
vovasty
force-pushed
the
vlad/build-ios13
branch
from
201daab to
b7b7126
Compare
rahul-malik
approved these changes
Oct 1, 2019
build.sh
Outdated
| @@ -1,7 +1,14 @@ | |||
| #!/bin/bash | |||
|
|
|||
| PLATFORM="${TEXTURE_BUILD_PLATFORM:-platform=iOS Simulator,OS=10.2,name=iPhone 7}" | |||
| SDK="${TEXTURE_BUILD_SDK:-iphonesimulator12.2}" | |||
| echo !!!! | |||
There was a problem hiding this comment.
Do we need these echo statements still or was this just for debugging?
There was a problem hiding this comment.
just debugging. There is no documentation how to switch Xcode.
vovasty
force-pushed
the
vlad/build-ios13
branch
from
522254a to
3d40aff
Compare
vovasty
force-pushed
the
vlad/build-ios13
branch
3 times, most recently
from
2b16d6e to
0a86408
Compare
vovasty
commented
Oct 3, 2019
vovasty
commented
Oct 3, 2019
| XCTAssertEqualObjects(NSStringFromCGRect(window.bounds), NSStringFromCGRect(node.frame)); | ||
| XCTAssertNotEqual(scrollNode.view.contentInset.top, 0); | ||
| XCTAssertEqual(scrollNode.view.contentInset.top, 0); |
There was a problem hiding this comment.
why it shouldn't be equal to zero?
vovasty
force-pushed
the
vlad/build-ios13
branch
10 times, most recently
from
e9d62ca to
a3a5fde
Compare
vovasty
force-pushed
the
vlad/build-ios13
branch
3 times, most recently
from
6b154f2 to
e43e774
Compare
vovasty
force-pushed
the
vlad/build-ios13
branch
from
0c601a1 to
cbffa3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode changed to 11
Simulator changed to iOS13 and iPhone 8
Fixed snapshot tests
Fixed tests that are depended on a separate
UIWindowDisabled
[ASDisplayNodeTests -testThatItIsAllowedToRetrieveDebugDescriptionIncludingVCOffMainThread]Weird changes to
[ASViewControllerTests -testThatAutomaticSubnodeManagementScrollViewInsetsAreApplied]and[ASDisplayNodeTests -checkValuesMatchDefaults]NB
ASRunLoopQueueTestsbecame flaky