Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hit point when ASCollectionNode inverted set to true #1781

Merged
merged 6 commits into from
Oct 6, 2020
Merged

Fix hit point when ASCollectionNode inverted set to true #1781

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f7cb1d
Account for possible inverted transform during hit test
bdolman Feb 27, 2020
84550c6
Merge branch 'master' into inverted-collection-node-hittest-fix
bdolman May 12, 2020
217a2c6
Store self.node and self.node.view in local variables for better read…
bdolman May 12, 2020
11a2f55
Merge remote-tracking branch 'texture/master' into inverted-collectio…
bdolman Sep 18, 2020
c4b206b
Add a test for hit testing in an inverted ASCollectionNode
bdolman Sep 18, 2020
5f7be24
Merge branch 'master' of https://github.com/TextureGroup/Texture into…
bdolman Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Source/Details/_ASCollectionViewCell.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ - (UIView *)hitTest:(CGPoint)point withEvent:(UIEvent *)event
* superclass hitTest:withEvent: implementation. If this returns a valid value we can go on with
* checking the node as it's expected to not be in one of these states.
*/
if (![super hitTest:self.bounds.origin withEvent:event]) {
CGPoint originPointOnView = [self convertPoint:self.node.view.bounds.origin fromView:self.node.view];
bdolman marked this conversation as resolved.
Show resolved Hide resolved
if (![super hitTest:originPointOnView withEvent:event]) {
return nil;
}

Expand Down