[example/CustomCollectionView] Implement MosaicCollectionLayoutDelegate #28
Conversation
nguyenhuy
force-pushed
the
HNPagerLayoutDelegate
branch
from
b5e49fb to
0c74571
Compare
| // This source code is licensed under the BSD-style license found in the | ||
| // LICENSE file in the root directory of this source tree. An additional grant | ||
| // of patent rights can be found in the PATENTS file in the same directory. | ||
| // Modifications to this file made after 4/13/2017 are: Copyright (c) 2017-present, |
There was a problem hiding this comment.
This new file uses many logics from MosaicCollectionViewLayout.m, hence this version of Copyright Notice.
nguyenhuy
force-pushed
the
HNPagerLayoutDelegate
branch
4 times, most recently
from
881d2db to
1b84899
Compare
nguyenhuy
force-pushed
the
HNPagerLayoutDelegate
branch
3 times, most recently
from
d8df6ab to
20d2198
Compare
| return [ASInsetLayoutSpec insetLayoutSpecWithInsets:UIEdgeInsetsZero child:_imageNode]; | ||
| return [ASInsetLayoutSpec insetLayoutSpecWithInsets:UIEdgeInsetsZero | ||
| child:[ASRatioLayoutSpec ratioLayoutSpecWithRatio:self.image.size.height/self.image.size.width | ||
| child:_imageNode]]; |
There was a problem hiding this comment.
Just to demonstrate best practice, might be worth having a CGSize imageSize = at the top
| ASElementMap *elements = context.elements; | ||
| CGFloat top = 0; | ||
|
|
||
| NSMapTable<ASCollectionElement *, UICollectionViewLayoutAttributes *> *attrsMap = [NSMapTable mapTableWithKeyOptions:(NSMapTableObjectPointerPersonality | NSMapTableWeakMemory) valueOptions:NSMapTableStrongMemory]; |
There was a problem hiding this comment.
This is a bit complex for sample code -- add a comment above for why it isn't just a dictionary?
|
|
||
| attrs.frame = frame; | ||
| [attrsMap setObject:attrs forKey:element]; | ||
| columnHeights[section][columnIndex] = @(CGRectGetMaxY(frame) + _interItemSpacing.bottom); |
There was a problem hiding this comment.
Vector might be worthwhile to avoid boxing - try profiling this first and look for object retain / release overhead. Apps will probably borrow this sample code and ship it :)
There was a problem hiding this comment.
Good point! Since this method is only called once for each data set, and in many cases on a background thread, I left a TODO instead of optimizing now.
There was a problem hiding this comment.
@nguyenhuy this is so exciting! I can't wait to try running it locally.
I think it would be worth a couple more performance optimizations for demonstrating best practices in core code, but this is subjective and not a correctness issue.
nguyenhuy
force-pushed
the
HNPagerLayoutDelegate
branch
from
50bc29e to
9350049
Compare
|
🚫 CI failed with log |
|
Looks like this needs a rebase. |
nguyenhuy
force-pushed
the
HNPagerLayoutDelegate
branch
from
9350049 to
994a35c
Compare
Generated by 🚫 Danger |
This is the first step in turning CustomCollectionView example into a playground for the coming async pager layout. It also helps identify components in the current system that don't play well with
ASCollectionLayoutand need to be improved/by-passed, such as ASRangeController, layout inspector, etc.Ticket: #186