Replace NSMutableSet with NSHashTable when Appropriate #trivial #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
changed the title
garrettmoon
approved these changes
May 31, 2017
Source/Layout/ASLayoutSpec.mm
Outdated
| @@ -170,11 +170,12 @@ - (ASTraitCollection *)asyncTraitCollection | |||
|
|
|||
| #pragma mark - Framework Private | |||
|
|
|||
| - (nullable NSSet<id<ASLayoutElement>> *)findDuplicatedElementsInSubtree | |||
| #if DEBUG | |||
There was a problem hiding this comment.
Should this be AS_DEDUPE_LAYOUT_SPEC_TREE?
| @@ -27,10 +27,12 @@ NS_ASSUME_NONNULL_BEGIN | |||
| NSMutableArray *_childrenArray; | |||
| } | |||
|
|
|||
| #if DEBUG | |||
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…ureGroup#321) * Use NSHashTable to avoid needless -hash and -isEqual: calls * Mark debug-only methods as such for clarity * Address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #312 and improves performance by replacing
-hashand-isEqual:with pointer work.