[ASDisplayNode+Layout] In layoutThatFits:, check and use _pending layout if valid. #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out if valid. I believe this check is supposed to be here. Unit tests pass with it in place. Without it, calling layoutThatFits: (as ASDataController does) and then calling it again later (as ASCollectionNode does when answering the sizeForItem: call) will recompute the layout, potentially on main. This seems to have more of an impact / benefit for Yoga layouts, but I don't think its benefit is exclusive to them.
Adlai-Holler
approved these changes
Jul 4, 2017
|
🚫 CI failed with log |
Generated by 🚫 Danger |
|
Just to be clear, the extra layout pass will occur if there is a valid pending layout but If that is the case then this diff actually makes perfect sense. I recall getting a report from a friend about extra layout passes triggered on main, in Why didn't we have catch this earlier? Or was the check there before but somehow removed? |
nguyenhuy
approved these changes
Jul 4, 2017
maicki
approved these changes
Jul 4, 2017
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…out if valid. (TextureGroup#413) I believe this check is supposed to be here. Unit tests pass with it in place. Without it, calling layoutThatFits: (as ASDataController does) and then calling it again later (as ASCollectionNode does when answering the sizeForItem: call) will recompute the layout, potentially on main. This seems to have more of an impact / benefit for Yoga layouts, but I don't think its benefit is exclusive to them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this check is supposed to be here. Unit tests pass with it in place.
Without it, calling layoutThatFits: (as ASDataController does) and then calling
it again later (as ASCollectionNode does when answering the sizeForItem: call)
will recompute the layout, potentially on main.
This seems to have more of an impact / benefit for Yoga layouts, but I don't think
its benefit is exclusive to them.