Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a potential deadlock; it's not safe to message likely super nod… #56

Merged
merged 3 commits into from
Apr 24, 2017
Merged

Fixes a potential deadlock; it's not safe to message likely super nod… #56

merged 3 commits into from
Apr 24, 2017

Conversation

garrettmoon
Copy link
Member

…es while holding the lock.

@garrettmoon garrettmoon force-pushed the fixPotentialDeadlock branch from 4833258 to a236df8 Compare April 21, 2017 16:19
nguyenhuy
nguyenhuy reviewed Apr 21, 2017
View reviewed changes
Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be simpler if we enumerate twice: first time to grab eventTargetActionArrays with the lock held and second time to consume them without the lock?

@garrettmoon
Copy link
Member Author

@nguyenhuy That's a better idea, will update.

@garrettmoon
Copy link
Member Author

@nguyenhuy hmmm, that actually increases the complexity of the code quite a bit. I need to keep 2 extra arrays around because responder could potentially be nil (so I can't use the original eventTargetActionArray). You think it's worth it?

@ghost
Copy link

ghost commented Apr 21, 2017

Build failure:
https://gist.githubusercontent.com/pinterest-ios/1e369c0921a030e76913dd882e9a4d95/raw/7586b927ce361f59d9f0e6e781fc890647e25ddb/results.txt

@nguyenhuy
Copy link
Member

nguyenhuy commented Apr 21, 2017 •
edited
Loading

@garrettmoon Can we have a single array of ASControlTargetAction? I might be missing something here. It's your call at this point :P

@garrettmoon garrettmoon force-pushed the fixPotentialDeadlock branch from a236df8 to 9fb1896 Compare April 24, 2017 18:03
nguyenhuy
nguyenhuy approved these changes Apr 24, 2017
View reviewed changes
Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garrettmoon garrettmoon merged commit 2d6ccdb into TextureGroup:master Apr 24, 2017
@CoderXL CoderXL mentioned this pull request Sep 28, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenhuy nguyenhuy nguyenhuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garrettmoon @nguyenhuy