[ASTextNode] Fix an race condition on ASTextKitAttributes #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@hebertialmeida This is a really reasonable fix that I didn't see before building #830. Despite the nice perf win you achieved, I think my fix is more targeted to the core issue – the unsafety of the ASTextKitAttributes struct. |
|
@Adlai-Holler Alright! so, should I close this one? |
|
@hebertialmeida Yes please. Sorry about that! |
|
No problem! Any idea when will #830 will get merged? |
|
@hebertialmeida Merged! |
|
Perfect! Thanks... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem was reported on #552 by @Kaspik some time ago.
Running the project with thread sanitizers enable show a bunch of errors due to a race condition on
ASTextKitAttributes, I spent some time looking at that and I found out that the race condition is happening onASTextNodewhenrendererForAttributestries to get and set the object to cache.This fixes the problem for me, I don't see any downsides to this implementation but of course, I would like to hear from your guys.
This could be false impressions, but I've noticed some performance improvement while rendering my app feed that has couple textNodes and I tried to measure that.
This is the average time (6 loads) to load a heavy cell with this code change:
with: 0.119627775
without: 0.141625549