add ASTextNode2 snapshot test

[wsdwsd0829]

Just copy over from ASTextNode and enable experiment.
// All tests are duplicated from ASTextNodeSnapshotTests.

[ghost]

🚫 CI failed with log

[nguyenhuy]

LGTM, but please check the failing tests. Thanks!

[wsdwsd0829]

Ok, I am a little confused, the tests seems so comparing images from TextNode1.
From what I recorded it locally, it supposed to create a new folder with name of this new test class.

Will try enable record mode and rely on CI to create snapshots itself and then disable it, hopefully it can fix CI fails.

[wsdwsd0829]

May needs some suggestions on this. It's seems comparing with TextNode1's images.

[Adlai-Holler]

It appears that FBSnapshotTestCase will use whatever reference image it matching the test selector that it finds first.

The code in - (NSString *)_referenceFilePathForSelector:(SEL)selector identifier:(NSString *)identifier doesn't know what class the selector is on.

The easiest fix is to rename the methods to e.g. testTextContainerInset2 and put a comment at the top explaining why we did and linking to this PR.

[ghost]

🚫 CI failed with log

[Adlai-Holler]

@wsdwsd0829 It looks like the issue is that the ASTextNode1 tests are running after the ASTextNode2 tests, and there's currently no way to go back to ASTextNode1 once you enable ASTextNode2.

So the TextNode1 tests are running with TextNode2 enabled.

[wsdwsd0829]

Interesting, I will revert setting in tear down then.

…

On Tue, May 29, 2018 at 11:53 AM Adlai Holler ***@***.***> wrote: @wsdwsd0829 <https://github.com/wsdwsd0829> It looks like the issue is that the ASTextNode1 tests are running after the ASTextNode2 tests, and there's currently no way to go *back* to ASTextNode1 once you enable ASTextNode2. So the TextNode1 tests are running with TextNode2 enabled. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#935 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFFq5ABhUHdn02EcfRED56YQcGtOgEXVks5t3Zk2gaJpZM4UJ3I0> .

[Adlai-Holler]

@wsdwsd0829 We're working on getting the CI back up and running.

[wsdwsd0829]

Thanks for suggestions and fixing this.

[Adlai-Holler]

Very great diff! This will let us iterate on ASTextNode2 safely ❤️