Fix for finding the longest word in terms of size instead of characte… #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Generated by 🚫 Danger |
Adlai-Holler
requested changes
May 3, 2017
There was a problem hiding this comment.
Hey thanks for the diff. We've seen thread-safety issues in the past with boundingRectWithSize: despite the claims of the documentation, and the performance penalty here is likely to be tremendous.
One improvement we can make off the bat is to avoid using rangeOfString: and instead use enumerateSubstrings which will give us the ranges directly. Beyond that, I'll try to find time to profile this change in the near future, but of course you're right that this algorithm is correct.
|
@Adlai-Holler @davevdveen Please follow up on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r count
Issue #94