Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: One Piece doesn't load and breaks app #568

Open
3 tasks done
Tendodeku opened this issue Oct 19, 2024 · 3 comments · May be fixed by #600
Open
3 tasks done

[Bug]: One Piece doesn't load and breaks app #568

Tendodeku opened this issue Oct 19, 2024 · 3 comments · May be fixed by #600
Labels
bug Something isn't working

Comments

@Tendodeku
Copy link

Tendodeku commented Oct 19, 2024 •
edited
Loading

Preflight checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I have searched the frequently asked questions for a solution that fixes this problem, without success.
  • I have checked that I'm using the latest stable version of the app.

What app version are you using?

v5.5.6

What operating system version are you using?

Windows

Expected Behavior

One piece episodes loads up then I select the episode and start watching.

Actual Behavior

After one piece is selected, it opens in now playing but doesn't show any episodes. Attached a screenshot of this. When it happens, the x button to leave now playing stops working and the only way to get out of it is to close the app completely. The app isn't frozen or anything, the x button just doesn't work anymore. I can still scroll and read the description and stuff but can't get out of that screen. After closing the app, there is a new issue that arises, this one isn't consistent but worth mentioning anyways. After closing the app due to the one piece issue, the first time starting up the app, it shows a java-script error. I attached a screenshot as well. It's not consistent but happens quite often.

Screenshots

Screenshot 2024-10-19 122620
Screenshot 2024-10-17 012851
@Tendodeku Tendodeku added the bug Something isn't working label Oct 19, 2024
@INFZeroT
Copy link

INFZeroT commented Oct 23, 2024 •
edited
Loading

PLSS FIX

Repository owner deleted a comment from 2547techno Dec 10, 2024
@2547techno
Copy link

@ThaUnknown not sure why my comment was deleted, it was relevant to this issue, did you want the stacktrace in text instead?

2547techno added a commit to 2547techno/miru that referenced this issue Dec 11, 2024
@2547techno
filter out null entries in list
0563c2f 
list can appear in the form:
```
[null, null {...}]
```
when anilist api does not return `episodeCount` number of episodes.

In the case of One Piece (ThaUnknown#568), only ep. 1122 is returned from the api,
leaving 1121 null's in the list before the first entry with actual
episode data
@2547techno 2547techno linked a pull request Dec 11, 2024 that will close this issue
Open
@2547techno
Copy link

did you want the stacktrace in text instead?

either way, the same stacktrace in text form is in the linked PR that closes this issue

Ju1-js pushed a commit to Ju1-js/miru that referenced this issue Jan 30, 2025
@2547techno @Ju1-js
fix: filter out null entries ep list
bbb35a1 
list can appear in the form:
```
[null, null {...}]
```
when anilist api does not return `episodeCount` number of episodes.

In the case of One Piece (ThaUnknown#568), only ep. 1122 is returned from the api,
leaving 1121 null's in the list before the first entry with actual
episode data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: filter out null entries in episode list 2547techno/miru
4 participants
@Tendodeku @INFZeroT @2547techno and others