Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PopArgument ts utility type #14

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Remove PopArgument ts utility type #14

merged 1 commit into from
Nov 4, 2024

Conversation

piotr-cz
Copy link
Contributor

@piotr-cz piotr-cz commented Nov 4, 2024 •
edited
Loading

There is no need to use PopArgument since zustand >= 4.1.3, which is now set to new minimum requirement
See pmndrs/zustand#1373

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@piotr-cz
Copy link
Contributor Author

piotr-cz commented Nov 4, 2024

Note:
Since this contains the zustand dependency bump (4.0.0 -> 4.1.3), this may be released in new minor version

@Thanaen Thanaen merged commit f0aa299 into Thanaen:main Nov 4, 2024
1 check passed
@piotr-cz piotr-cz deleted the feature/simplify-types branch November 4, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piotr-cz @Thanaen