Feature/disconnect improvement #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 1, 2020
|
Did you find any time to review this @ThanosFisherman ? |
|
No sorry @eliaslecomte couldn't find time. We are back at the office in my job and things are kind of crazy right now. Will try to review this during the weekend. Have you tested it yourself? |
No worries :-). I'll try test with multiple devices instead of just my own. |
wifiutils/src/main/java/com/thanosfisherman/wifiutils/ConnectorUtils.java
Outdated
Show resolved
Hide resolved
wifiutils/src/main/java/com/thanosfisherman/wifiutils/ConnectorUtils.java
Outdated
Show resolved
Hide resolved
wifiutils/src/main/java/com/thanosfisherman/wifiutils/ConnectorUtils.java
Outdated
Show resolved
Hide resolved
wifiutils/src/main/java/com/thanosfisherman/wifiutils/ConnectorUtils.java
Outdated
Show resolved
Hide resolved
|
@eliaslecomte Could you have a look at the comments above and make these minor corrections? Everything else seems good. Great job btw. |
|
Yes I will, thx for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is actually a difference between disconnecting and removing the wifi configuration pre android 10.
Solution
Add 2 new methods, disconnect and remove. Also kept disconnectFrom so a major version bump isn't required.