Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mother readout information wrong #100

Closed
The-Ludwig opened this issue Apr 2, 2024 · 0 comments · Fixed by #101
Closed

mother readout information wrong #100

The-Ludwig opened this issue Apr 2, 2024 · 0 comments · Fixed by #101

Comments

@The-Ludwig
Copy link
Owner

#80 introduced a huge bug where the information from the mother columns is not read out correctly.
(Since pandas is indexing with the dataframe index, where I intend to index with the integer index.)
All previous versions work fine.

Working on the fix right now, also adding a test case to catch this.
@The-Ludwig The-Ludwig mentioned this issue Apr 2, 2024
Merged
The-Ludwig added a commit that referenced this issue Apr 3, 2024
@The-Ludwig
Fix #100 (wrong parsing of mothers' hadron generation counter) (#101)
b197361 
- add test to catch bug from #100 
- allow `read_DAT` to parse filepath as `str`
- fix #100 
- bump version to 1.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #100 (wrong parsing of mothers' hadron generation counter) The-Ludwig/PANAMA
1 participant
@The-Ludwig