Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make pytables an optional dependency #89

Merged
merged 8 commits into from
Nov 9, 2023
Merged

make pytables an optional dependency #89

merged 8 commits into from
Nov 9, 2023

Conversation

The-Ludwig
Copy link
Owner

This fixes #84 and #86 . It also updates the documentation to use the silly panama logo

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #89 (cb0d4a3) into main (9a4fa2e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #89   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          779       788    +9     
=========================================
+ Hits           779       788    +9     
Files Coverage Δ
panama/cli/corsika_to_hdf5.py 100.00% <100.00%> (ø)
panama/version.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@The-Ludwig The-Ludwig merged commit ca0701c into main Nov 9, 2023
3 checks passed
@The-Ludwig The-Ludwig deleted the hdf branch November 9, 2023 01:45
The-Ludwig added a commit that referenced this pull request Nov 9, 2023
* update pre-commit hooks

* make it executable via 'python -m panama'

* make hdf an optional dependency

* add error message if trying to save with hdf without pytables being installed

* update README

* add test for module not found

* add no cover for unreachabel line with python 3.8
The-Ludwig added a commit that referenced this pull request Nov 9, 2023
* update pre-commit hooks

* make it executable via 'python -m panama'

* make hdf an optional dependency

* add error message if trying to save with hdf without pytables being installed

* update README

* add test for module not found

* add no cover for unreachabel line with python 3.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hdf as optional dependency
1 participant