Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate the clock in some STA reports #2134

Merged
merged 6 commits into from
Jul 18, 2024
Merged

Propagate the clock in some STA reports #2134

merged 6 commits into from
Jul 18, 2024

Conversation

kareefardi
Copy link
Collaborator

@kareefardi kareefardi commented Jul 1, 2024 •
edited by donn
Loading

  • Add conditional set_propagated_clocks for all clocks in base.sdc
    ~ Condition is true for:
    ~ CTS STA
    ~ Global routing STA
    ~ Global routing optimizations STA
    ~ Multicorner(signoff) STA
  • Add conditional set_propagated_clocks for all clocks after reading an sdc file depending on whether the statement is used in the sdc file for not. Idea is to be backwards compatible with the default behavior of OpenLane of propagating clocks outside the sdc file
  • Add a report for non-propagated clocks
  • Add a report for information regarding clocks

@kareefardi
propagate the clock in some STA reports
eea5485 
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
@kareefardi
Ignore _PROPAGATE_ALL_CLOCKS internal variable in CI variable documen…
acf195e 
…tation check

Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
@kareefardi kareefardi requested a review from donn July 1, 2024 07:54
@kareefardi
Duplicate argument
4a06378 
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
@kareefardi kareefardi marked this pull request as ready for review July 1, 2024 07:58
kareefardi and others added 3 commits July 1, 2024 12:17
@kareefardi
Add backwards compatible behavior to set_propagated_clock when not found
b991e06 
in sdc

Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
@kareefardi
Remove uneeded print
f8df8d2 
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
@donn
Merge remote-tracking branch 'origin/master' into fix-clock-propagationg
21f0c4a
donn
donn approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@donn donn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donn donn merged commit cdf98f3 into master Jul 18, 2024
15 checks passed
@donn donn deleted the fix-clock-propagationg branch July 18, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donn donn donn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kareefardi @donn