-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autotuner] Installation/ Sanity checks #2025
[Autotuner] Installation/ Sanity checks #2025
Conversation
…totuner docs Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
@luarss @maliberty Does this lock down the versions required in the system install for Python? That would be very bad as it is going to be version hell for other non-OpenROAD requirements on that same machine... If this is the case, I would recommend not installing into the system but using venv instead. That way autotuner can lock down versions of modules without worrying about non-OpenROAD python requirements. |
@oharboe I see. Tentatively I have thought of creating a “supported Python versions” list where we will route dependency installation for corresponding Python versions, but an easy way out is also to make Autotuner optional like you mentioned |
Are you familiar with venv? It is designed to easily and robustly solve exactly the problem you are facing, unless I misunderstand. With venv you create a "light weight installation"(takes at most a few seconds to set up) of Python where you can specify exactly the versions of modules that you want today using requirements.txt without disturbing the system installation. |
@oharboe You mean something like this? #!/bin/bash
venv_name="my_env"
python3 -m venv "$venv_name"
source "$venv_name/bin/activate"
pip install -r requirements.txt
deactivate |
Yes. |
… to error Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
…o ray (bugfix wip) Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write a unittest with mocking for python code so that it can be regression and implementation tested easily and add to CI.
github copilot/chatgpt will do 95% of the work in my experience.
Signed-off-by: Song Luar <espsluar@gmail.com>
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
Signed-off-by: Vitor Bandeira <vvbandeira@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questions...
Signed-off-by: luarss <39641663+luarss@users.noreply.github.com>
…low-scripts into at_improvement
Signed-off-by: luarss <39641663+luarss@users.noreply.github.com>
Signed-off-by: Vitor Bandeira <vvbandeira@users.noreply.github.com>
Signed-off-by: luarss <39641663+luarss@users.noreply.github.com>
…low-scripts into at_improvement
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
Signed-off-by: Song Luar <espsluar@gmail.com>
Signed-off-by: luarss <39641663+luarss@users.noreply.github.com>
@vvbandeira