Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtlmp: turn on by default #2216

Merged
merged 2 commits into from
Oct 2, 2024
Merged

rtlmp: turn on by default #2216

merged 2 commits into from
Oct 2, 2024

Conversation

oharboe
Copy link
Collaborator

@oharboe oharboe commented Aug 4, 2024

See what happens...

@oharboe
rtlmp: turn on by default
b9f84f6 
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@oharboe oharboe added the do not merge This PR is not intended to be merged label Aug 4, 2024
@oharboe oharboe changed the title [DO NOT REVIEW] rtlmp: turn on by default rtlmp: turn on by default Aug 4, 2024
@oharboe oharboe marked this pull request as ready for review August 4, 2024 14:11
@oharboe oharboe requested a review from maliberty August 4, 2024 14:12
@oharboe oharboe removed the do not merge This PR is not intended to be merged label Aug 4, 2024
@maliberty
Copy link
Member

This will have to go through a secure CI to see the impact there.

@oharboe
Copy link
Collaborator Author

oharboe commented Aug 5, 2024

This will have to go through a secure CI to see the impact there.

I expected as much. I was pleasantly surprised that there were no issues in public ORFS CI tests.

@oharboe oharboe mentioned this pull request Aug 5, 2024
Merged
@oharboe
Copy link
Collaborator Author

oharboe commented Aug 9, 2024

@maliberty are you taking this for a spin on the internal CI server? Would have been nice to have in the can.

@maliberty
Copy link
Member

I did and there were failures. I haven't had a chance to dig into them yet.

@oharboe
Copy link
Collaborator Author

oharboe commented Sep 6, 2024

@maliberty A loose end... Rabithole or close? Any idea?

@oharboe
Copy link
Collaborator Author

oharboe commented Oct 1, 2024

@maliberty @jeffng-or So now we're being bitten by regressions in RTLMP_FLOW=0 in bazel-orfs...

Can we push this over the finish line and put RTLMP_FLOW=0 to pasture?

@maliberty
Copy link
Member

I'll repeat the experiment as its been a while and see.

@maliberty
Copy link
Member

The CI looks fine (the only failure is in master and is similar).

@maliberty maliberty merged commit 389d859 into The-OpenROAD-Project:master Oct 2, 2024
5 of 6 checks passed
@oharboe oharboe deleted the rtlmp-default-on branch October 3, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliberty maliberty Awaiting requested review from maliberty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oharboe @maliberty