Conditionally Set KLAYOUT_VERSION Based on KLAYOUT_CMD #2219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally Set KLAYOUT_VERSION Based on KLAYOUT_CMD
This PR updates the
flow/Makefile
to conditionally set theKLAYOUT_VERSION
variable only ifKLAYOUT_CMD
is set. This change ensures that theKLAYOUT_VERSION
assignment is performed safely and only whenKLAYOUT_CMD
is defined, preventing potential errors whenKLAYOUT_CMD
is not set. These errors usually result in noisy logs, but they don't crash the build.An example error typically observed during the
synth
stage:This PR modifies the following:
flow/Makefile
- Updates the assignment ofKLAYOUT_VERSION
to use the$(if ...)
function to check ifKLAYOUT_CMD
is set before executing the shell command. Also, fixes typos.