[Docs] CI for variables.yaml + CI for docs update #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oharboe
suggested changes
Oct 13, 2024
oharboe
reviewed
Oct 16, 2024
luarss
force-pushed
the
topic/yaml-tests
branch
from
b64ab9e to
e26f811
Compare
oharboe
suggested changes
Nov 9, 2024
|
@oharboe FlowVariables.md changes are detected in the update-pr section. Do you mean to shift it up to the lint section? |
|
I am thinking this is more linting than testing, yes. It is fast enough.... |
maliberty
reviewed
Nov 9, 2024
yamlfix.toml
Outdated
| @@ -0,0 +1,11 @@ | |||
| explicit_start = true | |||
| line_length = 120 | |||
There was a problem hiding this comment.
It looks like it is being wrapped at 80 characters not 120. 80 is preferable as it match Google style for c++. Does this do anything?
There was a problem hiding this comment.
Yes, it does. The command to run for check is yamlfix -c yamlfix.toml flow/scripts/variables.yaml --check, whereas for format is yamlfix -c yamlfix.toml flow/scripts/variables.yaml. Next PR should reflect line length 80.
luarss
force-pushed
the
topic/yaml-tests
branch
from
50c1d09 to
a50fc37
Compare
luarss
force-pushed
the
topic/yaml-tests
branch
from
4c8cb75 to
3c60cba
Compare
Signed-off-by: Jack Luar <jluar@precisioninno.com>
…ction Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
luarss
force-pushed
the
topic/yaml-tests
branch
from
3c60cba to
8751209
Compare
vvbandeira
reviewed
Jan 29, 2025
vvbandeira
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked in #2452
Fixes #2444