AT doc update #2556
Closed
AT doc update #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeffng-or
commented
Nov 8, 2024
jeffng-or
commented
- Moved tune-specific arguments to their own section
- Added Defaults column to arguments since not documented
- minor typo fix in message
luarss
reviewed
Nov 9, 2024
flow/scripts/variables.yaml
Outdated
Comment on lines
614
to
615
| Whether to perform metal density filling. | ||
| default: 0 (=off) |
There was a problem hiding this comment.
Suggested change
| Whether to perform metal density filling. | |
| default: 0 (=off) | |
| Whether to perform metal density filling. (0 means off) | |
| default: 0 |
this can keep defaults easily convertable to correct types
Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
jeffng-or
force-pushed
the
at-doc-update
branch
from
85e00ea
to
4b0fb4f
Compare
luarss
reviewed
Nov 13, 2024
| @@ -81,7 +81,7 @@ configuration file. | |||
| | <a name="DESIGN_NICKNAME"></a>DESIGN_NICKNAME| DESIGN_NICKNAME just changes the directory name that ORFS outputs to be DESIGN_NICKNAME instead of DESIGN_NAME in case DESIGN_NAME is unwieldy or conflicts with a different design.| | | |||
| | <a name="DETAILED_METRICS"></a>DETAILED_METRICS| If set, then calls report_metrics prior to repair operations in the CTS and global route stages| 0 | | |||
| | <a name="DETAILED_ROUTE_ARGS"></a>DETAILED_ROUTE_ARGS| Add additional arguments for debugging purposes during detail route.| | | |||
| | <a name="DETAILED_ROUTE_END_ITERATION"></a>DETAILED_ROUTE_END_ITERATION| Maximum number of iterations.| 64 | | |||
| | <a name="DETAILED_ROUTE_END_ITERATION"></a>DETAILED_ROUTE_END_ITERATION| Maximum number of iterations| 64 | | |||
There was a problem hiding this comment.
Stray edit? I think it differs from variables.yaml
https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/blob/master/flow/scripts/variables.yaml
|
Closing this PR and using #2557 instead. 2557 only modifies the InstructionsForAutoTuner.md and distributed.py files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.