pdn: correct the instance obstruction calculation #4117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maliberty
approved these changes
Oct 10, 2023
Use max(halo, min_space) rather than halo + min_space to bloat the instance. This was causing gf12/tinyRocket to fail due to false strap / obs overlap. Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
openroad-robot
force-pushed
the
pdn-obs-fix
branch
from
2690920 to
bebcca3
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
gadfort
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use max(halo, min_space) rather than halo + min_space to bloat the instance. This was causing gf12/tinyRocket to fail due to false strap / obs overlap.