Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grt: Improving the incremental GRT runtime #4728

Merged

Conversation

luis201420
Copy link
Contributor

Improving the incremental GRT runtime.

  • Avoiding checking and iterating all the nets in each Fastrouter step.
  • Avoiding calling the checkPinPlacement function in each incremental GRT iteration.

…g all nets

Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
…RT iterations

Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/grt/src/fastroute/src/RSMT.cpp Outdated Show resolved Hide resolved
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Copy link
Contributor

github-actions bot commented Mar 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

src/grt/src/fastroute/src/utility.cpp Outdated Show resolved Hide resolved
src/grt/src/fastroute/src/utility.cpp Outdated Show resolved Hide resolved
src/grt/src/fastroute/include/FastRoute.h Outdated Show resolved Hide resolved
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
Copy link
Contributor

github-actions bot commented Mar 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
Copy link
Contributor

github-actions bot commented Mar 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

github-actions bot commented Mar 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
Copy link
Contributor

github-actions bot commented Mar 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
Copy link
Contributor

github-actions bot commented Mar 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
eder-matheus and others added 3 commits March 12, 2024 18:03
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@eder-matheus eder-matheus merged commit 6aea4f9 into The-OpenROAD-Project:master Mar 14, 2024
13 checks passed
@eder-matheus eder-matheus deleted the grt_incr_improving_runtime branch March 14, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants