-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marker Batch Rename Panel #80
Comments
A few thoughts - I'm familiar with A Better Finder Rename - awesome tool and I've been using it for probably over 10 years. Worth every penny!
As I've stated in the past, MarkersExtractor is just a data extractor with limited formatting options for pre-determined output profiles. Once you get its output, you are free to do what you like with it. Post-processing or additional formatting of data is primarily a Marker Data feature here. What you decide to do with it is, again, up to you. If you want to write it back to the JSON/CSV/TSV file, that would be your responsibility and discretion. I suppose there could be an access point in the MarkersExtractor library (not CLI) that would allow manipulation of the data model before exporting the manifest and other files to disk.
This is a new feature all on its own - essentially a "FCPXML Export Profile". It would make more sense in a hypothetical future when more input data sources than just FCPXML may be possible. Currently DAWFileKit has the ability to edit existing FCPXML and/or author a new FCPXML from scratch. We just haven't needed it since we've only been treating FCPXML as a source and not an export format/profile. Which leads to a bigger question of: what exactly are you wanting to achieve? It feels like batch processing just the Name and Notes fields is an arbitrarily limited application of the necessary engineering that would be needed to build to achieve it. You could do a lot more with it. A few other thoughts:
|
Thanks for the input, Steffan!
Same here!
While creating Marker database for VFX/Review/Editorial is the main purpose of Marker Data. The seconday purpose would be the creation of Personal Shot/Frame Library for Reference. Something similar to Shot Deck. It was one of the primary motivation to add colour palette #17.
Marker.Rename.Idea.-.1.mp4Once they have renamed their markers, they can perform extraction using Marker.Rename.Idea.-.2.mp4User can upload to Notion database. Marker.Rename.Idea.-.3.mp4
I strongly believe, Marker Data manipulating the JSON/CSV/TSV file is not the best or ideal approach. Users would always want to have a backup of their Library with movie reference clips. They would want to make sure that the markers listed in the Timeline is identical to JSON/CSV/TSV file. Which means, manipulation occurs not at the final JSON/CSV/TSV stage, but rather at the FCPXML stage.
Yes, RegEx would be a great feature. This batch marker rename could also be useful for batch renaming VFX Shot IDs. |
Final Cut really doesn't help here, yeah. You can't even drag markers to reposition them. Feels very claustrophobic and archaic. I'm pretty sure it has no batch rename either - you're relegated to editing single markers at a time.
Right, and I wouldn't recommend editing the output files any way.
There's kind of 2 different things going on here. One is the concept of mutating the FCPXML data before MarkersExtractor performs its extraction. Another is rewriting a FCPXML file, regardless of whether we actually want to continue with extraction or not. I'd want to clarify the use cases so that the API makes sense. |
https://commandpost.io/faq/#why-did-you-remove-moveable-markers One of the reason why most FCP users would usually place markers on
Not sure if an intermediate json cache file would make sense. Marker Data would read/write to the json cache file. During the writing process, the API would use the json cache file to write/update the FCPXML. |
That's a lot more work than necessary really. The library could be adapted to just give you its manifest data model without writing any files to disk. Would just require a few changes in the code to make it accessible. |
This feature would be a small app in itself. We should first see how users actually use Marker Data, and then we can decide if enough users would use this feature. Maybe we can poll to see if this is a feature people would like to see. |
True. But since Marker Data, deals with Markers, it somewhat makes sense to have this feature. That way, Marker Data becomes an all encompassing application for FCP's Makers. As a user of FCP, I kinda hate the idea installing multiple apps to solve and augment different workflows needs.
Certainly. But, this batch rename feature can be vital toolkit of Maker Data, because of the above mentioned reasons. |
@IAmVigneswaran This is how I would implement the rename panel. Instead of the Before, Rename Options and After panels I would combine everything into a single panel. Also I would simplify the process a bit. This is how I would do it:
We can do the same for notes. We don't need any intermediate JSON or anything. Because we are only renaming notes and markers we don't need any complicated logic, I can just use an XML parser I think. Maybe @orchetect can help with reading and writing the actual |
You shouldn't be touching XML at all. That's what MarkersExtractor is for.
Like I said, I can add API to return all marker data that would otherwise be contained in a CSV as an object in memory instead. Is this process pre- or post- processing with a profile? That gets a bit more complicated because you would need to modify the data at some point in the middle of the process that MarkersExtractor performs. |
I think this reveals the fact that MarkersExtractor is really doing two jobs. It's parsing out markers from FCPXML, but it's also processing the data in order to conform to output profiles. Those two processes could be split and it could be possible to invoke them separately. |
Oh, nice. So if I understand well I need the "raw" data to change the marker names (best would be some Swift object), then a way to save this modified data back into |
No, you would modify the data then just return the object to MarkersExtractor to complete the process. |
Writing back to FCPXML is non-trivial and not something we can reliably do yet. |
Yes, that's what I meant. So if I'm correct, MarkersExtractor would have two functions. Something along the lines of |
I'm not sure how I'm not being clear. Once we ingest FCPXML, that's it. We can't go back to it at this time. We have to use the parsed data as our own format. Instead of a single call to MarkersExtractor to convert FCPXML to profile output files, it can be two calls. First call returns an in-memory data object that can be modified. You modify it, and then call the second call passing the modified data object in and the process completes as usual. If you want to save the data at that in-between step then that complicates things. |
I believe, technically this is a pre-processing? Cause this rename API call/write feature is an additional internal library feature that would not be available in our CLI.
And this feature is separate from our dedicated extract profiles.
Yes, I believe we can optimise the workflow better? Some ideas. I also have some ideas from a popular free windows tool, Bulk Rename Utility In Bulk Rename Utility the rename preview is always LIVE. That means, the users will always able preview the new name live. Taking the same concept, yes, Instead of the In the Preview Panel, We can have 4 Columns. Each time when users make changes in the
Ideas: We can have just 2 Call? One to When users drag and drop their timeline into Marker Data's Workflow Extension, Marker Data would use the Once users are satisfied with the new rename of both/or Markers and Notes, Users can press |
Definitely possible on the MarkersExtractor side.
I think this would serve all of the needs you've described. |
No. Line numbers are brittle and naive. There are better ways to reference markers. We already have a marker ID as an identifier included in the manifest, for one. There could be an additional manifest field that contains an XML path which would be the ideal way to positively identify FCPXML nodes.
It's possible if we have XML paths as mentioned above. I could provide API to update existing marker information in FCPXML that way.
Is this involving Marker Data, a Final Cut extension, or both? I'm a bit confused here. Do you mean Marker Data will be able to rename markers as part of its process, but the user will also want to re-import the markers back to their FCP project? Or is this something entirely contained in the FCP extension with renaming and re-importing back to FCP? I'm not sure it makes sense to send the entire FCPXML back to Final Cut? What does it do with it? Is there not a scenario where only the markers on a bare timeline should be sent to it?
This feels kind of clunky. Is this the only way? |
Noted! Just wanted to make sure there are no conflicts when the value of the Markers / Notes are identical.
Yes. Both. Users would use the Workflow Extension to Drag and Drop the timeline into the
Yes, that is the idea. Using the Once, Renamed, Marker Data can use Write API. And MarkersExtractor would use the updated
Yes. 100% In all professional workflows, users would want to re-import back their timeline. This is a video some 7 years go. But you can see that user would always want to re-import back their timeline. https://www.youtube.com/watch?v=A1Diuxkf8E4 Up coming Multicam Flattener app. You can see, that even though the new imported timeline has Multicam Flatten, all the timeline and all other stuff is pretty much intact. https://www.youtube.com/watch?v=Y2Ezd4F2clQ
The idea is we have new Tab in the Marker Data's Workflow Extension for Drop & Drop the Timelines. Once the data is received, it would automatically launch our Main Marker Data app for all the renaming manipulation.
It does make sense to send the complete intact timeline. And that is what the users are expecting.
No. Because in FCP there is no concept of Users can have super complex feature length timeline with 500+ clips. They can retimed, have effects and multi-cam clips and etc. At any given time, users can have 100+ Markers with notes. And users would want batch rename them in one go. And they want to re-import back the new timeline. Once they are happy with the renaming, they can delete their original timeline from their FCP Browser.
Nope. Not at all, re-importing timelines or events is a common practice in the FCP. Check out the above videos. |
Ok, makes sense. This seems doable. |
@milanvarady This is somethings we can look into after the release of 1.0.0.
Maybe during version 1.2.0 or 1.3.0.
Just made a quick mockup.
Rename
Panel can be place afterQueue
Panel.Rename Options
tab to set and configure their preference.Batch Rename
Marker Data would write back / save into the FCPXML file.i
orgear
button would have pre-defined codes/syntax.Some ideas
https://www.publicspace.net/ABetterFinderRename/index.html
https://renamer.com/
@orchetect I am wondering if we could add any special API call for MarkersExtractor or DAWFileKit to achieve this in a optimal fashion?
Open to suggestions and ideas.
Thank you.
The text was updated successfully, but these errors were encountered: