Update stack_using_linked_lists.c #620
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added comments and time complexities.
Panquesito7
requested changes
Sep 30, 2020
Panquesito7
requested changes
Sep 30, 2020
| @@ -36,40 +36,47 @@ int main() | |||
| } | |||
| } | |||
|
|
|||
| void push(struct node *p) | |||
| /** | |||
| * push function will add a new node at the head of the list, time complexity O(1). | |||
There was a problem hiding this comment.
Missing parameter documentation.
Same in other parts of the code.
Panquesito7
reviewed
Sep 30, 2020
| { | ||
| int item; | ||
| struct node *temp; | ||
| temp = (struct node *)malloc(sizeof(struct node)); | ||
| temp = (struct node *)malloc(sizeof(struct node)); |
There was a problem hiding this comment.
Please remove this empty whitespace.
Same in other parts of the code.
Suggested change
| temp = (struct node *)malloc(sizeof(struct node)); | |
| temp = (struct node *)malloc(sizeof(struct node)); |
Panquesito7
added
Admin views requested
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added comments and time complexities.