Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Mean Squared Logarithmic Error (MSLE) Loss Function #10637

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

ank426
Copy link
Contributor

@ank426 ank426 commented Oct 17, 2023

Describe your change:

I have added MSLE loss function which is very useful when dealing with regression problems involving skewed or large-value targets.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 17, 2023
@cclauss
Copy link
Member

cclauss commented Oct 17, 2023

This directory of loss functions is less compelling than I thought because each is three lines or less of algorithmic code.

The files are about 100 lines long with comments, doctests, validation code, and other boilerplate. It takes a lot of clicking in and out of files to review all of the various loss functions.

Would we be better off making a single loss_functions.py that contains all these functions so that they can be studied side-by-side without all the opening and closing of files?

@tianyizheng02
Copy link
Contributor

Would we be better off making a single loss_functions.py that contains all these functions so that they can be studied side-by-side without all the opening and closing of files?

Sounds good to me. Once we're done handling the existing loss function PRs we can open a new PR to consolidate all of the loss functions.

@ank426
Copy link
Contributor Author

ank426 commented Oct 19, 2023

Would we be better off making a single loss_functions.py that contains all these functions so that they can be studied side-by-side without all the opening and closing of files?

Sounds good to me. Once we're done handling the existing loss function PRs we can open a new PR to consolidate all of the loss functions.

Hey so could you please accept the PR, or are there any changes I have to make?

@tianyizheng02 tianyizheng02 merged commit bd3072b into TheAlgorithms:master Oct 19, 2023
2 checks passed
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
…hms#10637)

* Added Mean Squared Logarithmic Error (MSLE)

* Added Mean Squared Logarithmic Error (MSLE)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants