Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new subdirectory for special numbers #10714

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

tianyizheng02
Copy link
Contributor

Describe your change:

Created a subdirectory within maths/ called special_numbers/ for algorithms that compute numbers with special properties: perfect numbers, polygonal numbers, Carmichael numbers, etc. This should make it easier to find such files within the maths/ directory.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 19, 2023
@tianyizheng02
Copy link
Contributor Author

tianyizheng02 commented Oct 19, 2023

Error: machine_learning/sequential_minimum_optimization.py:457:19: S310 Audit URL open for permitted schemes. Allowing use of `file:` or custom schemes is often unexpected.
Error: Process completed with exit code 1.

The ruff error's not from any of the files I moved...

Update: error fixed

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 20, 2023
@tianyizheng02 tianyizheng02 requested a review from cclauss October 20, 2023 04:42
@cclauss cclauss enabled auto-merge (squash) October 20, 2023 06:17
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cclauss cclauss merged commit 6f2d6f7 into TheAlgorithms:master Oct 20, 2023
2 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 20, 2023
@tianyizheng02 tianyizheng02 deleted the nums branch October 20, 2023 06:18
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants