Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mergesort.py #2441

Closed
wants to merge 1 commit into from
Closed

Update mergesort.py #2441

wants to merge 1 commit into from

Conversation

LuisEnMarroquin
Copy link

@LuisEnMarroquin LuisEnMarroquin commented Sep 16, 2020 •
edited
Loading

Allow the function to be executed without having to pass the start and end indexes of the array

Describe your change:

Added default values to mergesort function to automatically calculate the start and end indexes

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Improved an algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@LuisEnMarroquin
Update mergesort.py
86d37f5 
Allow the function to be executed without having to pass the start and end indexes of the array
cclauss
cclauss reviewed Sep 17, 2020
View reviewed changes
divide_and_conquer/mergesort.py
[0, 1, 1, 2, 2, 3, 3, 4, 5]
"""
if left is None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if left is None:
left = left or 0

All other falsy values are as equally dangerous as None.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, GitHub is not allowing me to send an extra commit to this pull request, I'll close this in favor of #2444

Copy link
Member

@cclauss cclauss Sep 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the upper right of the file, you should see three dots (...). Click that and select Edit file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't, apparently github doesn't allow adding more commits if you remove your folk

image

@LuisEnMarroquin
Copy link
Author

Closed in favour of #2444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LuisEnMarroquin @cclauss