-
-
Notifications
You must be signed in to change notification settings - Fork 46k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise error not string #7945
Merged
cclauss
merged 15 commits into
TheAlgorithms:master
from
CaedenPH:raise-error-not-string
Nov 6, 2022
Merged
Raise error not string #7945
cclauss
merged 15 commits into
TheAlgorithms:master
from
CaedenPH:raise-error-not-string
Nov 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms-keeper
bot
added
enhancement
This PR modified some existing files
awaiting reviews
This PR is ready to be reviewed
labels
Nov 2, 2022
Apparently I've accidentally pushed the |
for more information, see https://pre-commit.ci
…python into raise-error-not-string
cclauss
reviewed
Nov 2, 2022
Fixing checks... |
cclauss
reviewed
Nov 2, 2022
Co-authored-by: Christian Clauss <cclauss@me.com>
@cclauss I'll apply that |
Pre-commit failed due to error mentioned in #7940 but build workflow is 👍 |
for more information, see https://pre-commit.ci
cclauss
reviewed
Nov 2, 2022
Co-authored-by: Christian Clauss <cclauss@me.com>
@cclauss I made the requested changes - pre-commit still failing due to the |
cclauss
reviewed
Nov 6, 2022
Pre-commit is alive! |
cclauss
approved these changes
Nov 6, 2022
algorithms-keeper
bot
removed
the
awaiting reviews
This PR is ready to be reviewed
label
Nov 6, 2022
Cjkjvfnby
pushed a commit
to Cjkjvfnby/Python
that referenced
this pull request
Mar 13, 2023
* ci: Add `B023` to `.flake8` ignores * refactor: Return `bool`/raise Exception * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * revert: Remove previous branch commit * Update data_structures/binary_tree/segment_tree_other.py Co-authored-by: Christian Clauss <cclauss@me.com> * feat: Apply `__repr__` changes * chore: Fix failing tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update data_structures/binary_tree/segment_tree_other.py Co-authored-by: Christian Clauss <cclauss@me.com> * test: Fix doctests * random.choice(population_score[:N_SELECTED])[0] * Update basic_string.py Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Replaces string errors with raising exceptions
Checklist:
Fixes: #{$ISSUE_NO}
.