Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes github install dotnet from global.json #234

Merged
merged 2 commits into from
Mar 14, 2021

Conversation

TheAngryByrd
Copy link
Owner

@TheAngryByrd TheAngryByrd commented Mar 14, 2021

Proposed Changes

Makes github install dotnet from global.json

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@TheAngryByrd TheAngryByrd force-pushed the github-workflow-build-alignment branch from 9b2ff73 to f9bb6c0 Compare March 14, 2021 10:04
@TheAngryByrd TheAngryByrd merged commit 725e1ec into master Mar 14, 2021
@TheAngryByrd TheAngryByrd deleted the github-workflow-build-alignment branch March 14, 2021 10:35
TheAngryByrd added a commit that referenced this pull request Mar 14, 2021
## [0.26.3-beta001] - 2021-03-14

### Fixed
- Fixes GitHub Workflow FAKE integration from [@TheAngryByrd](https://github.com/TheAngryByrd) - #232
- Makes devcontainers more flexible with dotnet versions from [@TheAngryByrd](https://github.com/TheAngryByrd) - #233
- Makes github workflow install dotnet from global.json from [@TheAngryByrd](https://github.com/TheAngryByrd) - #234
TheAngryByrd added a commit that referenced this pull request Mar 14, 2021
## [0.26.3] - 2021-03-14

### Fixed
- Fixes GitHub Workflow FAKE integration from [@TheAngryByrd](https://github.com/TheAngryByrd) - #232
- Makes devcontainers more flexible with dotnet versions from [@TheAngryByrd](https://github.com/TheAngryByrd) - #233
- Makes github workflow install dotnet from global.json from [@TheAngryByrd](https://github.com/TheAngryByrd) - #234
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant