pin Octokit to 0.48 until FAKE is upgraded #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
added a commit
that referenced
this pull request
May 28, 2021
## [0.27.0-beta002] - 2021-05-28 ### Changed - FSharp-Analyzers updated to 0.9.0, global.json version update to 5.0.300, MSBuild.StructuredLogger pinned to 2.1.500 from[@TheAngryByrd](https://github.com/TheAngryByrd)) - - #244 - Octokit pinned to 0.48 from [@enovales](https://github.com/enovales) - #243 - Using TargetFramework in projects because we're only targeting net5.0 from [@TheAngryByrd](https://github.com/TheAngryByrd)) - #241 ### Added - Adds README to nuget package which will be displayed on nuget.org from [@TheAngryByrd](https://github.com/TheAngryByrd)) - #242
TheAngryByrd
added a commit
that referenced
this pull request
May 28, 2021
## [0.27.0] - 2021-05-28 ### Changed - FSharp-Analyzers updated to 0.9.0, global.json version update to 5.0.300, MSBuild.StructuredLogger pinned to 2.1.500 from[@TheAngryByrd](https://github.com/TheAngryByrd) - #244 - Octokit pinned to 0.48 from [@enovales](https://github.com/enovales) - #243 - Using TargetFramework in projects because we're only targeting net5.0 from [@TheAngryByrd](https://github.com/TheAngryByrd)) - #241 ### Added - Adds README to nuget package which will be displayed on nuget.org from [@TheAngryByrd](https://github.com/TheAngryByrd)) - #242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Pin Octokit to 0.48, until fsprojects/FAKE#2594 is merged and released in FAKE. Currently, the scaffold pulls in a floating version of Octokit through FAKE. Octokit had a breaking interface change in 0.50 to UploadAsset, which broke FAKE in turn.
Until that is resolved, this unbreaks the scaffold, and allows GitHub releases to succeed.
Types of changes
Checklist
Further comments