Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AssemblyInfo and other interesting properties to be set #57

Merged
merged 1 commit into from
Feb 25, 2018

Conversation

TheAngryByrd
Copy link
Owner

Closes #49 .

Proposed Changes

The new fsproj format does not yet generate AssemblyInfo dotnet/fsharp#3113 so we need to set this ourselves using FAKE's assembly generation

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

The new fsproj format does not yet generate assemblyinfo dotnet/fsharp#3113 so we need to set this ourselves using FAKE's assembly genereation
@TheAngryByrd TheAngryByrd merged commit e8470bb into master Feb 25, 2018
TheAngryByrd pushed a commit that referenced this pull request Feb 25, 2018
* BUGFUX: AssemblyVersion not showing (#57)
* MINOR:  Added documentation to template's README/md (#56)
TheAngryByrd pushed a commit that referenced this pull request Mar 1, 2018
* BUGFUX: AssemblyVersion not showing (#57)
* MINOR:  Added documentation to template's README/md (#56)
@TheAngryByrd TheAngryByrd deleted the 49-assembly-version branch December 24, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assembly Version not listed
1 participant