Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating readme #871

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

Jan-NiklasB
Copy link

I updated the readme and added a german translation (as spoken of in the discord)

Jan-NiklasB and others added 3 commits February 21, 2023 18:34
- Update run instructions in README.md
- Add language Buttons to README.md
- Add README.de-DE.md with german translation
@xezon
Copy link
Contributor

xezon commented Feb 21, 2023

Now we can choose between this and #815

README.md Outdated Show resolved Hide resolved
@@ -2,6 +2,9 @@
[![linux](https://github.com/TheAssemblyArmada/Thyme/workflows/linux/badge.svg)](https://github.com/TheAssemblyArmarda/Thyme/actions)
[![codecov](https://codecov.io/gh/TheAssemblyArmada/Thyme/branch/develop/graph/badge.svg)](https://codecov.io/gh/TheAssemblyArmada/Thyme)

[![en-GB](https://img.shields.io/badge/lang-en--GB-green.svg)](https://github.com/TheAssemblyArmada/Thyme/README.md)
[![de-DE](https://img.shields.io/badge/lang-de--DE-green.svg)](https://github.com/TheAssemblyArmada/Thyme/README.de-DE.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need German page for this? Adds maintenance overhead. I would expect that anyone tech savvy will be able to read English, after all source code is English too.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, was simply an idea as the translation isn't a big deal for me and I can tell you that there're way too much germans not abled to understand english in a acceptable way....

We could integrate the last change date in the top, so one will see if it's outdated


To run Thyme, you first need to have Command & Conquer Generals: Zero Hour installed. If you don't have the original game disc, Generals: Zero Hour can currently be bought most easily as a downloadable version that is part of the Command & Conquer The Ultimate Collection from [Origin](https://www.origin.com/en-us/store/command-and-conquer/command-and-conquer-the-ultimate-collection/ultimate-collection) or a third-party like [Amazon](https://www.amazon.com/Command-Conquer-Ultimate-Collection-PC/dp/B0095C0I4W).
**As of now (Feb. 2023) Thyme only runs on Windows and must be compiled by yourself.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There actually is a pre-compiled thyme, which another contributor has attempted to highlight with change #815.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An this does work as expected?
I mean if thats the case I'd ask myself why I did the whole compiling thing and nobody told me on DC.
Also OmniBlade stated that the binary is very limited in functionality, so would that really be helpful for the normal user?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well if it's working and wanted I can include this in the readme, just let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants