Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean init #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clean init #2

wants to merge 2 commits into from

Conversation

atombrella
Copy link

It also replicates here now :) However, links is legacy docker, so it should go. I added https://github.com/eficode/wait-for as well.

Copy link
Owner

@TheDukeDK TheDukeDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the wait for script ensures postgres is ready to accept connections then the corresponding code should be removed from the entrypoint wrapper.sh script.

Copy link
Owner

@TheDukeDK TheDukeDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename 02-create-schema.sql to 01-create-schema.sql.

docker-compose.yaml Show resolved Hide resolved
docker-compose.yaml Show resolved Hide resolved
@atombrella
Copy link
Author

Wait merging this!

@TheDukeDK
Copy link
Owner

@atombrella - No I won't merge it. The wrapper script needs to have the db wait stuff pulled out since it is replaced with the wait-for script. Plus we should rename the schema file to be 01.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants