-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean init #2
base: master
Are you sure you want to change the base?
Clean init #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the wait for script ensures postgres is ready to accept connections then the corresponding code should be removed from the entrypoint wrapper.sh script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename 02-create-schema.sql
to 01-create-schema.sql
.
Wait merging this! |
@atombrella - No I won't merge it. The wrapper script needs to have the db wait stuff pulled out since it is replaced with the wait-for script. Plus we should rename the schema file to be 01. |
It also replicates here now :) However,
links
is legacy docker, so it should go. I added https://github.com/eficode/wait-for as well.