Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WritingMode.TRUNCATE_EXISTING no longer works with AsyncFileConfig #181

Closed
LambdAurora opened this issue Jul 30, 2024 · 0 comments
Closed

WritingMode.TRUNCATE_EXISTING no longer works with AsyncFileConfig #181

LambdAurora opened this issue Jul 30, 2024 · 0 comments
Assignees
@TheElectronWill
Labels
bug 🐛 core ⚙️

Comments

@LambdAurora
Copy link

With night-config 3.8.0, using auto-saving (or any kind of saving) with AsyncFileConfig is a guarantee for a catastrophic failure since
the fileWriter instance is never closed and continuously re-used, which prevents from using the configuration and saving it multiple times, as doing so will only pile on the configuration multiple times in the fileWriter without resetting it.
This effectively makes the TRUNCATE_EXISTING void.
@TheElectronWill TheElectronWill changed the title Catastrophic failure of saving with AsyncFileConfig WritingMode.TRUNCATE_EXISTING no longer works with AsyncFileConfig Jul 31, 2024
@TheElectronWill TheElectronWill self-assigned this Jul 31, 2024
TheElectronWill added a commit that referenced this issue Jul 31, 2024
@TheElectronWill
Merge pull request #182 from TheElectronWill/async-fileconfig-fixes
511114e 
Fix some AsyncFileConfig issues, resolve #181, resolve #180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheElectronWill TheElectronWill

Labels
bug 🐛 core ⚙️
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheElectronWill @LambdAurora