Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analyzer and long report templates #1196

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Fix analyzer and long report templates #1196

merged 1 commit into from
Aug 4, 2023

Conversation

TonioRyo
Copy link
Contributor

Fixes added to the Sekoia.io analyzers:

  • Add a taxonomy observables known in Sekoia.io without indicated threats
  • Fix long report templates - reports were not displayed when the analyzer returns more than 1 result

@jeromeleonard jeromeleonard self-requested a review August 1, 2023 08:19
@jeromeleonard jeromeleonard added category:enhancement Issue is related to an existing feature to improve scope:analyzer Issue is analyzer related priotiry:high category:bugfix labels Aug 1, 2023
@jeromeleonard jeromeleonard added this to the 3.3.0 milestone Aug 1, 2023
Copy link
Contributor

@jeromeleonard jeromeleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Updating report templates will generate issues for older reports in TheHive. To ensure users will be able to visualise older reports correctly and new reports as well, we recommend increasing the version of the Analyzer when updating them.

Several actions are required:

  • Updating json file for each flavor impacted and change 1.0 to 1.1 ("version": "1.0", to "version": "1.1",)
  • updating templates folder names:
    • thehive-templates/SEKOIAIntelligenceCenter_Context_1_0/ to thehive-templates/SEKOIAIntelligenceCenter_Context_1_1/
    • thehive-templates/SEKOIAIntelligenceCenter_Indicators_1_0/ to thehive-templates/SEKOIAIntelligenceCenter_Indicators_1_1/
    • thehive-templates/SEKOIAIntelligenceCenter_Observables_1_0/ to thehive-templates/SEKOIAIntelligenceCenter_Observables_1_1/

Copy link
Contributor

@jeromeleonard jeromeleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made a mistake. this is a bug fix in track by. So we can keep the version.

@jeromeleonard jeromeleonard merged commit d7cf2aa into TheHive-Project:develop Aug 4, 2023
@TonioRyo TonioRyo deleted the fix/sekoia-io-analyzer-template branch August 9, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bugfix category:enhancement Issue is related to an existing feature to improve priotiry:high scope:analyzer Issue is analyzer related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants