Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cortex and boolean ConfigurationItems #309

Closed
jeromeleonard opened this issue Oct 15, 2020 · 0 comments
Closed

[Bug] Cortex and boolean ConfigurationItems #309

jeromeleonard opened this issue Oct 15, 2020 · 0 comments
Assignees
Labels
Milestone

Comments

@jeromeleonard
Copy link
Contributor

jeromeleonard commented Oct 15, 2020

Request Type

Bug

Problem Description

Cortex ignores defaultValue of configurationItems of type boolean when this one is set to false.
For example with FileInfo:

Configuration
"configurationItems": [
    {
      "name": "manalyze_enable",
      "description": "Wether to enable manalyze submodule or not.",
      "type": "boolean",
      "required": true,
      "multi": false,
      "defaultValue": false
    },
    {
      "name": "manalyze_enable_docker",
      "description": "Use docker to run Manalyze. Can be used only if not using the docker image of FileInfo",
      "type": "boolean",
      "required": false,
      "multi": false,
      "defaultValue": false
    },
    {
      "name": "manalyze_enable_binary",
      "description": "Use local binary to run Manalyze. Need to compile it before!",
      "type": "boolean",
      "required": false,
      "multi": false,
      "defaultValue": false
    },
Results

image

Configuration

What happens when some are set to true ?

  {
      "name": "manalyze_enable",
      "description": "Wether to enable manalyze submodule or not.",
      "type": "boolean",
      "required": true,
      "multi": false,
      "defaultValue": true
    },
    {
      "name": "manalyze_enable_docker",
      "description": "Use docker to run Manalyze. Can be used only if not using the docker image of FileInfo",
      "type": "boolean",
      "required": false,
      "multi": false,
      "defaultValue": false
    },
    {
      "name": "manalyze_enable_binary",
      "description": "Use local binary to run Manalyze. Need to compile it before!",
      "type": "boolean",
      "required": false,
      "multi": false,
      "defaultValue": true
    },
Result in Cortex

image

@nadouani nadouani self-assigned this Oct 15, 2020
@nadouani nadouani added this to the 3.1.0-RC2 milestone Oct 15, 2020
nadouani added a commit that referenced this issue Oct 28, 2020
nadouani added a commit that referenced this issue Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants