Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CA Certs parameter can't be set back to null #377

Closed
cyberpescadito opened this issue Jul 8, 2021 · 1 comment
Closed

[BUG] CA Certs parameter can't be set back to null #377

cyberpescadito opened this issue Jul 8, 2021 · 1 comment
Assignees
Milestone

Comments

@cyberpescadito
Copy link

Request Type

Bug

Work Environment

Question Answer
OS version (server) Debian
OS version (client) iOS
Cortex version / git hash 3.1.1-1
Package Type Docker
Browser type & version Chrome 91.0.4472.114

Problem Description

When applying a parameter to the "CA Cert" field, it's not possible to go back to the "null" value.
if you leave the "CA Certs" field empty, it will define an empty string ( "" ) as cert path, triggering "OpenSSL.SSL.Error: [('x509 certificate routines', 'X509_load_cert_crl_file', 'no certificate or crl found')]" error.
This behaviour is applicable to analyzers/responders config, and to global configurations.
It means if you configure a certificate in your global configuration, then remove this parameter, every analyzer/responder will have an empty string as "CA Cert" parameter and all jobs will fail (the CA Certs parameter set to "" is invisible to the user)

Steps to Reproduce

  1. apply a parameter to the field "CA Certs" on an analyzer
  2. remove this parameter from the analyzer config
  3. any job run by this analyzer will fail with 'no certificate or crl found' error.

Possible Solutions

when the CA Certs field is changed to "", define it as null

@cyberpescadito cyberpescadito changed the title [BUG] [BUG] CA Certs parameter can't be set back to null Jul 8, 2021
@cyberpescadito
Copy link
Author

cyberpescadito commented Jul 8, 2021

Workaround:
modify the front-end requests when changing the config in the UI.
replace "" by null in the request at parameter cacerts

@nadouani nadouani self-assigned this Jul 8, 2021
@nadouani nadouani added this to the 3.1.2 milestone Jul 8, 2021
@To-om To-om modified the milestones: 3.1.5, 3.1.6 May 24, 2022
@To-om To-om modified the milestones: 3.1.6, 3.1.7 Jun 22, 2022
To-om added a commit that referenced this issue Oct 5, 2022
@To-om To-om closed this as completed Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants